HACK: Temporary workaround for glColor3ub crash on macOS #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glColor3ub is causing SEGFAULT on negative values, use glColor3i instead. See LWJGL/lwjgl3#858 This call is rarely used so performance impact should be minimal.
eigenraven
approved these changes
Feb 15, 2023
pftbest
added a commit
to pftbest/lwjgl3ify
that referenced
this pull request
Feb 17, 2023
See GTNewHorizons#17 Found out that Botania is using 4ub variant, we need to patch it too.
Dream-Master
pushed a commit
that referenced
this pull request
Feb 17, 2023
See #17 Found out that Botania is using 4ub variant, we need to patch it too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glColor3ub is causing SEGFAULT on negative values on macOS, use glColor3i instead.
See LWJGL/lwjgl3#858
This call is rarely used so performance impact should be minimal.