Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: consolidate base classes #183

Merged
merged 2 commits into from
Sep 15, 2024

Conversation

nstarman
Copy link
Contributor

No description provided.

Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Copy link

codecov bot commented Sep 15, 2024

Codecov Report

Attention: Patch coverage is 95.91837% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.66%. Comparing base (876c14a) to head (7bf8c53).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/coordinax/_coordinax/base/base_pos.py 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
- Coverage   95.73%   95.66%   -0.07%     
==========================================
  Files          70       71       +1     
  Lines        2720     2701      -19     
==========================================
- Hits         2604     2584      -20     
- Misses        116      117       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nstarman nstarman marked this pull request as ready for review September 15, 2024 17:40
@nstarman nstarman merged commit f9051b8 into GalacticDynamics:main Sep 15, 2024
14 checks passed
@nstarman nstarman deleted the refactor-base branch September 15, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant