Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat(vecs): new function vector for constructing vectors #320

Merged
merged 5 commits into from
Dec 29, 2024

Conversation

nstarman
Copy link
Contributor

This also simplifies a lot of the vector constructors.

@nstarman nstarman added this to the v0.17.x milestone Dec 29, 2024
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.22%. Comparing base (14611e2) to head (969a320).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
+ Coverage   97.94%   98.22%   +0.28%     
==========================================
  Files         122      122              
  Lines        3890     3891       +1     
==========================================
+ Hits         3810     3822      +12     
+ Misses         80       69      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nstarman nstarman force-pushed the vecs/simplify-dispatches branch from 500de8e to 19f6e60 Compare December 29, 2024 01:36
the `from_` constructors now use this

Signed-off-by: Nathaniel Starkman <nstarman@users.noreply.github.com>
@nstarman nstarman force-pushed the vecs/simplify-dispatches branch from 7a4d666 to 969a320 Compare December 29, 2024 02:24
@nstarman nstarman marked this pull request as ready for review December 29, 2024 04:19
@nstarman nstarman merged commit 3a1e799 into GalacticDynamics:main Dec 29, 2024
18 checks passed
@nstarman nstarman deleted the vecs/simplify-dispatches branch December 29, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant