♻️ refactor(vecs): astropy constructors #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #321 +/- ##
=======================================
Coverage 98.22% 98.22%
=======================================
Files 122 122
Lines 3884 3897 +13
=======================================
+ Hits 3815 3828 +13
Misses 69 69 ☔ View full report in Codecov by Sentry. |
nstarman
force-pushed
the
vecs/simplify-dispatches
branch
3 times, most recently
from
19a3d6b to
729d03d
Compare
Signed-off-by: Nathaniel Starkman <nstarman@users.noreply.github.com>
nstarman
force-pushed
the
vecs/simplify-dispatches
branch
from
729d03d to
bba0e48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
restructure the vector constructors from astropy objects, also adding the UnitSpherical ones.