Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The PipelineML extract_pipeline_catalog should be private #100

Closed
Galileo-Galilei opened this issue Oct 20, 2020 · 0 comments · Fixed by #101
Closed

The PipelineML extract_pipeline_catalog should be private #100

Galileo-Galilei opened this issue Oct 20, 2020 · 0 comments · Fixed by #101
Assignees
@Galileo-Galilei
Labels
bug Something isn't working
Milestone
Release 0.4.0

Comments

@Galileo-Galilei
Copy link
Owner

Description

The PipelineML extract_pipeline_catalog method should be private. Indeed it is never intended to be used directly by the user, unlike extract_pipeline_artifact.

Context

The documentation and code suggest the user can used extract_pipeline_catalog when they should ot use it directly. extract_pipeline_artifacts should be used instead.

Solution

Rename extract_pipeline_catalog to indicate it is private.
@Galileo-Galilei Galileo-Galilei self-assigned this Oct 20, 2020
@Galileo-Galilei Galileo-Galilei added this to the Release 0.4.0 milestone Oct 20, 2020
Galileo-Galilei added a commit that referenced this issue Oct 20, 2020
@Galileo-Galilei
FIX #100 - Make PipelineML._extract_pipeline_catalog private
761e511
@Galileo-Galilei Galileo-Galilei mentioned this issue Oct 20, 2020
Merged
6 tasks
@Galileo-Galilei Galileo-Galilei linked a pull request Oct 20, 2020 that will close this issue
Feature/pipeline ml inputs #101
Merged
6 tasks
@Galileo-Galilei Galileo-Galilei added the bug Something isn't working label Oct 23, 2020
Galileo-Galilei added a commit that referenced this issue Oct 25, 2020
@Galileo-Galilei
FIX #100 - Make PipelineML._extract_pipeline_catalog private
31604f0
Galileo-Galilei added a commit that referenced this issue Oct 26, 2020
@Galileo-Galilei
FIX #100 - Make PipelineML._extract_pipeline_catalog private
6e94a8f
takikadiri pushed a commit that referenced this issue Oct 27, 2020
@Galileo-Galilei @takikadiri
FIX #100 - Make PipelineML._extract_pipeline_catalog private
1c9bba2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Galileo-Galilei Galileo-Galilei

Labels
bug Something isn't working
Projects
None yet
Milestone
Release 0.4.0
Development

Successfully merging a pull request may close this issue.

Feature/pipeline ml inputs Galileo-Galilei/kedro-mlflow
1 participant
@Galileo-Galilei