Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup mlflow configuration when context is loaded #124

Closed
Galileo-Galilei opened this issue Nov 21, 2020 · 2 comments · Fixed by #238
Closed

Setup mlflow configuration when context is loaded #124

Galileo-Galilei opened this issue Nov 21, 2020 · 2 comments · Fixed by #238
Assignees
Labels
enhancement New feature or request need-design-decision Several ways of implementation are possible and one must be chosen

Comments

@Galileo-Galilei
Copy link
Owner

Description

When I call load_context() interactively, the configuration of the mlflow.yml is:

  • not accessible through a context attributes
  • not set up (especially, the mlflow tracking uri is not set)

Context

I always struggle when i want to use the configuration in the mlflow.yml interactively. This makes experimentation & debugging harder.

Possible Implementation

For now, I can't see how it is possible to modify the context object to add attributes. We can eventually add some to the catalog with the after_catalog_created hook, but the configuration should not be tied to the catalog execution.

@Galileo-Galilei Galileo-Galilei added enhancement New feature or request need-design-decision Several ways of implementation are possible and one must be chosen labels Nov 21, 2020
@takikadiri
Copy link
Collaborator

takikadiri commented Nov 22, 2020

I understand the point, but to my knowledge the kedro context do not manage plugins properties, it just use them to supercharge his own properties (catalog, params, pipelines)

It isn't sufficient for you to get the config by calling the get_mlflow_config of kedro_mlflow ?

context = load_context(Path.cwd())
mlflow_config = get_mlflow_config(context)

@Galileo-Galilei
Copy link
Owner Author

The current implementation seems indeed satisfying enough (with kedro>=0.17 and the a KedroSession activated, it can be simplified to

from kedro_mlflow.framework.context
mlflow_config=get_mlflow_config()
mlflow_config.setup()

However, we should setup automatically the configuration for jupyter, through the %reload_kedro line magic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request need-design-decision Several ways of implementation are possible and one must be chosen
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants