-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kedro-mlflow is broken with kedro==0.18.1 #309
Labels
bug
Something isn't working
Comments
Galileo-Galilei
added a commit
that referenced
this issue
May 15, 2022
Galileo-Galilei
added a commit
that referenced
this issue
May 15, 2022
Galileo-Galilei
added a commit
that referenced
this issue
May 15, 2022
Closed by #313 |
Galileo-Galilei
added a commit
that referenced
this issue
May 30, 2022
Galileo-Galilei
added a commit
that referenced
this issue
May 30, 2022
Galileo-Galilei
added a commit
that referenced
this issue
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
The plugin does not work with projects created with
kedro==0.18.1
Context
Try to launch
kedro run
in a project withkedro==0.18.1
and kedro-mlflow installed.Steps to Reproduce
Expected Result
This should run the pipeleine and log the parameters.
Actual Result
This raises the following error:
Your Environment
Include as many relevant details about the environment in which you experienced the bug:
kedro
andkedro-mlflow
version used (pip show kedro
andpip show kedro-mlflow
):kedro==0.18.1
andkedro-mlflow<=0.9.0
python -V
): AllDoes the bug also happen with the last version on master?
Yes
Solution
Currently, kedro-mlflow uses the private
_active_session
global variable to access the configuration inside a hook.With kedro==0.18.1, this private attribute was removed and the new recommandation is to use the
after_context_created
hook.Retrieving the configuration and set it up should be moved to this new hook:
kedro-mlflow/kedro_mlflow/framework/hooks/pipeline_hook.py
Lines 108 to 109 in 963c338
The text was updated successfully, but these errors were encountered: