Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_generate_kedro_command fails if context.run() arguments are None #50

Closed
Galileo-Galilei opened this issue Aug 23, 2020 · 0 comments · Fixed by #51
Closed

_generate_kedro_command fails if context.run() arguments are None #50

Galileo-Galilei opened this issue Aug 23, 2020 · 0 comments · Fixed by #51

Comments

@Galileo-Galilei
Copy link
Owner

Description

The _generate_kedro_command is called inside the MlflowPipelineHook (and generate a kedro command from the Journal information and store it in mlflow for further reproducibility. The current implementation makes if tests that fails if parameters Journal arguments are None and accepts only empty iterables. This works when kedro run is invoked through the CLI (because empty arguments are passed as empty list), but fails when context.run() is called in interactive mode because default values are None.

Proposed solution

Changes tests from

to

if from_inputs:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant