Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MlflowDataSet fails to log on remote storage when underlying dataset filepath is converted as a PurePosixPath #74

Closed
Galileo-Galilei opened this issue Sep 30, 2020 · 0 comments · Fixed by #75
Labels
bug Something isn't working
Milestone

Comments

@Galileo-Galilei
Copy link
Owner

Galileo-Galilei commented Sep 30, 2020

When I register a dataset in the catalog.yml

my_dataset:
  type : kedro_mlflow.io.MlflowDataSet 
  data_set : 
    type: pickle.PickleDataSet
    filepath: data/02_intermediate/my_dataset.pkl

and I run kedro run I got a expected string or bytes-like object when the local path is linux AND the mlflow_tracking_uri is an Azure blob storage (it works locally). I don't know really why this append, but it can be fied by replacing self._filepath by self._filepath.as_posix() in these 2 locations:

local_path=local_path,

mlflow.log_artifact(local_path, self.artifact_path)

@kaemo @akruszewski did you experience some issues with S3 too?

EDIT: @akruszewski it is the very same issue you encountered here

@Galileo-Galilei Galileo-Galilei added the bug Something isn't working label Sep 30, 2020
@Galileo-Galilei Galileo-Galilei added this to the Release 0.3.0 milestone Sep 30, 2020
@Galileo-Galilei Galileo-Galilei changed the title MlflowDataSet fails when underlying dataset filepath is converted as a PurePosixPath MlflowDataSet fails to log on remote storage when underlying dataset filepath is converted as a PurePosixPath Oct 1, 2020
Galileo-Galilei added a commit that referenced this issue Oct 1, 2020
…f a PurePosixPath for logging on remote storage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant