Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #105 - Remove deprecated pipeline_ml and MlflowDataSet #108

Merged
merged 1 commit into from
Oct 31, 2020

Conversation

Galileo-Galilei
Copy link
Owner

@Galileo-Galilei Galileo-Galilei commented Oct 30, 2020

Description

Close #105 by removing deprecated pipeline_ml and MlflowDataSet

Development notes

  • remove tests, import and definitions of these functions

Checklist

  • Read the contributing guidelines
  • Open this PR as a 'Draft Pull Request' if it is work-in-progress
  • Update the documentation to reflect the code changes
  • Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
  • Add tests to cover your changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@codecov-io
Copy link

codecov-io commented Oct 30, 2020

Codecov Report

Merging #108 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #108   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          629       618   -11     
=========================================
- Hits           629       618   -11     
Impacted Files Coverage Δ
kedro_mlflow/io/mlflow_dataset.py 100.00% <ø> (ø)
kedro_mlflow/pipeline/pipeline_ml_factory.py 100.00% <ø> (ø)
kedro_mlflow/io/__init__.py 100.00% <100.00%> (ø)
kedro_mlflow/pipeline/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08f0645...6f79658. Read the comment docs.

@Galileo-Galilei Galileo-Galilei merged commit 9adb5ef into develop Oct 31, 2020
@Galileo-Galilei Galileo-Galilei deleted the feature/rm-deprecated-0.4.0 branch October 31, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Deprecated pipeline_ml and MlflowDataSet
2 participants