Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #187 - Pass host and port parameters from the configuration to the ui command and enable runtime overwriting #189

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

Galileo-Galilei
Copy link
Owner

@Galileo-Galilei Galileo-Galilei commented Apr 9, 2021

Description

Fix #187

Development notes

  • Change default port and host configuration to match mlflow's ones (in the mlflow.yml template and in KedroMlflowConfig)
  • Pass host and port to when calling mlflow ui inside kedro mlflow ui
  • Add host and port arguments to ui to enable to overwrite these parameters at runtime

Checklist

  • Read the contributing guidelines
  • Open this PR as a 'Draft Pull Request' if it is work-in-progress
  • Update the documentation to reflect the code changes
  • Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
  • Add tests to cover your changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

…e ui command and enable runtime overwriting
@Galileo-Galilei Galileo-Galilei merged commit 330fb11 into master Apr 9, 2021
@Galileo-Galilei Galileo-Galilei deleted the bug/cmd-ui branch April 9, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kedro mlflow ui does not use arguments from mlflow.yml
1 participant