Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ 💥 Change PipelineML signature to pass kwargs to mlflow.pyfunc.log_model and KedroPipelineModel #265

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

Galileo-Galilei
Copy link
Owner

@Galileo-Galilei Galileo-Galilei commented Nov 9, 2021

Description

Close #67

Development notes

What have you changed, and how has this been tested?

Checklist

  • Read the contributing guidelines
  • Open this PR as a 'Draft Pull Request' if it is work-in-progress
  • Update the documentation to reflect the code changes
  • Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
  • Add tests to cover your changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@Galileo-Galilei Galileo-Galilei changed the title ✨ 💥 Change PipelineML signature to pass kwargs to mlflo…w.pyfunc.log_model and KedroPipelineModel ✨ 💥 Change PipelineML signature to pass kwargs to mlflow.pyfunc.log_model and KedroPipelineModel Nov 9, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #265 (1a174d3) into master (257642f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #265   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines          923       897   -26     
=========================================
- Hits           923       897   -26     
Impacted Files Coverage Δ
kedro_mlflow/pipeline/pipeline_ml_factory.py 100.00% <ø> (ø)
kedro_mlflow/framework/hooks/pipeline_hook.py 100.00% <100.00%> (ø)
kedro_mlflow/pipeline/pipeline_ml.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 257642f...1a174d3. Read the comment docs.

@Galileo-Galilei Galileo-Galilei marked this pull request as ready for review November 11, 2021 09:47
@Galileo-Galilei Galileo-Galilei merged commit b71ecf2 into master Nov 11, 2021
@Galileo-Galilei Galileo-Galilei deleted the feature/log-code-in-model branch November 11, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the KedroPipelineModel more portable
2 participants