Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 💥 Remove kedro_mlflow_line magic and mlflow_client gloabl variable in notebooks (#349) #369

Merged
merged 1 commit into from
Oct 9, 2022

Conversation

Galileo-Galilei
Copy link
Owner

Description

Close #349

Development notes

  • remove kedro_mlflow.extras folder
  • cleanup setup.py entrypoints

Checklist

  • Read the contributing guidelines
  • Open this PR as a 'Draft Pull Request' if it is work-in-progress
  • Update the documentation to reflect the code changes
  • Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
  • Add tests to cover your changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@Galileo-Galilei Galileo-Galilei linked an issue Oct 9, 2022 that may be closed by this pull request
@Galileo-Galilei Galileo-Galilei force-pushed the 349-remove-reload_kedro_mlflow-line-magic branch from 08a0d0c to 7deb521 Compare October 9, 2022 11:12
@codecov-commenter
Copy link

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (7deb521) compared to base (4c90a98).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #369   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        27    -1     
  Lines          912       898   -14     
=========================================
- Hits           912       898   -14     

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Galileo-Galilei Galileo-Galilei merged commit ec73e7e into master Oct 9, 2022
@Galileo-Galilei Galileo-Galilei deleted the 349-remove-reload_kedro_mlflow-line-magic branch October 9, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove reload_kedro_mlflow line magic
2 participants