Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor codes and tests to match kedro==0.19 conventions #467

Merged
merged 4 commits into from
Oct 25, 2023

Conversation

Galileo-Galilei
Copy link
Owner

@Galileo-Galilei Galileo-Galilei commented Oct 22, 2023

Description

Prepare kedro 0.19 release

Development notes

  • fix failing tests due to cookiecutter hooks
  • 💥 rename all data_set entries int eh code by dataset. This changes the signature of MLflowArtifactDataSet.
  • Refactor tests to remove logging monkeypatching. this makes tests simpler.

Notice that tests do not pass because we are on the latest 0.18.x version, but they dont pass either on the develop branch because of following issues: kedro-org/kedro#3214

Checklist

  • Read the contributing guidelines
  • Open this PR as a 'Draft Pull Request' if it is work-in-progress
  • Update the documentation to reflect the code changes
  • Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
  • Add tests to cover your changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@Galileo-Galilei Galileo-Galilei changed the title Fix-cookiecutter Refactor codes and tests to match kedro==0.19 conventions Oct 22, 2023
@Galileo-Galilei Galileo-Galilei marked this pull request as ready for review October 25, 2023 19:39
@Galileo-Galilei Galileo-Galilei merged commit b0c953b into master Oct 25, 2023
2 of 15 checks passed
@Galileo-Galilei Galileo-Galilei deleted the fix-cookiecutter branch October 25, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant