Enhance unlock_bootloader with better status messages #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Detect bootloaders that are already unklocked - Detect bootloader unlock success - Detect bootloaders that cannot be unlocked - Detect devices which have not enabled bootloader unlocking
zachriggle
force-pushed
the
dev
branch
2 times, most recently
from
2a32645 to
b53e58a
Compare
Arusekk
reviewed
Dec 8, 2019
| def __eq__(self, other): | ||
| # Allow simple comparison, e.g.: | ||
| # adb.properties.ro.oem_unlock_supported == "1" | ||
| return type(other)(self) == other |
There was a problem hiding this comment.
This causes strange behavior in sphinx testing environment, when being compared against None (they should not do it in the first place, since is None is the preferred way).
Also I don't think that we need anything but str here.
Suggested change
| return type(other)(self) == other | |
| return str(self) == other |
Arusekk
added a commit
to HenryHoggard/pwntools
that referenced
this pull request
Dec 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.