Prevent Python3 installation via "pip3 install pwntools" #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pwntools does not work on Python3, so that it installs successfully is misleading.
More information on 'python_requires' can be found here:
https://packaging.python.org/tutorials/distributing-packages/#python-requires
Specifically, it requires pip 9.0 or better -- but this is the 'official' way to do this.
Fixes Gallopsled#1092
TethysSvensson
approved these changes
Jan 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pwntools does not work on Python3, so that it installs successfully is misleading.
More information on 'python_requires' can be found here:
Specifically, it requires pip 9.0 or better -- but this is the 'official' way to do this.
Fixes #1092