corefile: also expose page_offset #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase this on |
This is useful to load the code from the original files.
|
Rebased... |
|
I made some quick changes to preserve the original ordering of the constructor arguments -- I'll merge this if/when CI passes 😄 |
Mic92
commented
Jun 13, 2018
pwnlib/elf/corefile.py
Outdated
| @@ -184,12 +187,13 @@ def __str__(self): | |||
| return '%x-%x %s %x %s' % (self.start,self.stop,self.permstr,self.size,self.name) | |||
|
|
|||
| def __repr__(self): | |||
| return '%s(%r, start=%#x, stop=%#x, size=%#x, flags=%#x)' \ | |||
| return '%s(%r, start=%#x, stop=%#x, size=%#x, page_offset=%#x, flags=%#x)' \ | |||
pwnlib/elf/corefile.py
Outdated
| Mapping('/lib/i386-linux-gnu/ld-2.19.so', start=0xf7712000, stop=0xf7713000, size=0x1000, flags=0x4), | ||
| Mapping('/lib/i386-linux-gnu/ld-2.19.so', start=0xf7713000, stop=0xf7714000, size=0x1000, flags=0x6), | ||
| Mapping('[stack]', start=0xfff3e000, stop=0xfff61000, size=0x23000, flags=0x6)] | ||
| [Mapping('/home/user/pwntools/crash', start=0x8048000, stop=0x8049000, size=0x1000, page_offset=0x0, flags=0x5), |
|
It shouldn’t matter since:
1) The doctest is still correct (repr() returns that string)
2) That repr() is still valid since it uses **kwargs instead of ordered arguments
|
|
I just toughed it is more consistent. |
|
Definitely -- feel free to fix it if you'd like, I just didn't want to make a large edit in the browser (and still ended up needing to make 3 edits 😅) |
|
Done. The current failure is just a temporary connection problem to ftp.ubuntu.org: https://travis-ci.org/Gallopsled/pwntools/builds/391975461#L1456 |
|
Restarted the CI build after fixing #1172 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pwntools Pull Request
Adds page_offset to corefiles. This is useful to data from the original files.
This pull request depends on: #1167
Testing
tested via testsuite and:
$ gdb ls -batch -ex 'break _start' -ex run -ex 'generate-core-file core'