Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am surveying the possibility of integrating Capstone/Keystone as mentioned in #683. This is a pretty early and untested draft, but I want to bring up some discussion.
Here are some of my implementation choices.
libkeystone.so
. I have to compile it manually. Do we want to do this insetup.py
for users?cpp
to supportSYS_xxx
.Unlike binutil, 32-bit Sparc and PowerPC will not throw any exception when assembling 64-bit instructions. Capstone doesn't have corresponding 32-bit mode for Sparc and PowerPC. Should we fallback to binutil for them?
5. For implementation simplicity,
disasm
would showinstead of
Besides, the spacing is also slightly different.
Any suggestions on these points?