Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeout parameter passing in sendlineafter and other similar functions #1277

Merged
merged 4 commits into from
Aug 27, 2019

Conversation

lockshaw
Copy link
Contributor

sendlineafter (and other similar functions) currently pass the timeout paramter to the drop parameter of recvuntil. This causes sendlineafter to completely ignore the timeout parameter. This PR fixes this behavior.

@lockshaw
Copy link
Contributor Author

lockshaw commented Apr 3, 2019

Any plans to merge this in?

Copy link
Member

@Arusekk Arusekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix is fine for me, I don't know if it changes any semantics, but if so, only for better

@Arusekk Arusekk requested a review from zachriggle May 8, 2019 13:04
@lockshaw
Copy link
Contributor Author

lockshaw commented Jul 3, 2019

@Arusekk It does change semantics, currently the arguments are passed in the wrong order

@lockshaw
Copy link
Contributor Author

@Arusekk What still needs to get done for this to be merged in?

@Arusekk
Copy link
Member

Arusekk commented Aug 26, 2019

@zachriggle I can't merge stable, it looks great, and should be merged imo

@zachriggle
Copy link
Member

@Arusekk I think it just needs to be rebased. There should be an update branch button.

Separately, I've made you into a Project Admin so you should be able to do ~= anything. Note that the restricted branches (stable and beta) can't be pushed to directly even by admins.

@Arusekk Arusekk merged commit 5d27987 into Gallopsled:stable Aug 27, 2019
@zachriggle
Copy link
Member

@Arusekk please make sure to merge stable => beta and then beta => dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants