Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement property getter/setter for context.newline, and make tubes honor it #1541

Merged
merged 5 commits into from
Oct 13, 2020

Conversation

heapcrash
Copy link
Collaborator

The default newline can now be set context-wide, or per-tube.

>>> t = tube()
>>> t.newline = 'X'
>>> t.unrecv('A\nB\nCX')
>>> t.recvline()
b'A\nB\nCX'

>>> t = tube()
>>> context.newline = '\r\n'
>>> t.newline
b'\r\n'

@heapcrash heapcrash added this to the 4.3.0 milestone Jun 3, 2020
@heapcrash heapcrash requested a review from Arusekk June 3, 2020 12:49
pwnlib/tubes/tube.py Outdated Show resolved Hide resolved
pwnlib/tubes/tube.py Outdated Show resolved Hide resolved
@heapcrash heapcrash modified the milestones: 4.3.0, Someday Jun 9, 2020
heapcrash added 2 commits July 3, 2020 20:19
…honor it

The default newline can now be set context-wide, or per-tube.
@heapcrash heapcrash force-pushed the use-context-newline-for-tubes branch from ac25cdc to ffb8e1e Compare July 4, 2020 01:19
@Arusekk Arusekk merged commit e47c65c into Gallopsled:dev Oct 13, 2020
@heapcrash heapcrash deleted the use-context-newline-for-tubes branch May 31, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants