tubes/remote: Support Server Name Indication and enable by default #1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows customizing the server_name via sni="custom" or sending the name specified in the host parameter via sni=True. We switch to the SSLContext.wrap_socket API because ssl.wrap_socket is deprecated and does not support SNI. Unfortunately, SSLContext.wrap_socket dropped some of the parameters that are supported by ssl.wrap_socket. These parameters have been moved to the SSLContext API and can now be used by passing a custom SSLContext to the ssl_context parameter of `remote`.
Arusekk
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: Allow tubes to connect to TLS services that do server name based matching.
This allows customizing the server_name via
sni="custom.com"or sendingthe name specified in the host parameter via
sni=True.Implementation:
This switches to the SSLContext.wrap_socket API because ssl.wrap_socket is
deprecated and does not support SNI.
Unfortunately, SSLContext.wrap_socket dropped some of the parameters
that are supported by ssl.wrap_socket. These parameters have been moved
to the SSLContext API and can now be used by passing a custom SSLContext
to the ssl_context parameter of
remote.This PR changes the default settings for all
tls=Truetubes and includes backwards-incompatible changes! Feel free to close/reject.