[shellcraft] Avoid recursive walk of all templates for command line #1651
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mechanism is much faster (up to ~5x)
Before:
pwn shellcraft i386.linux.sh 0.57s user 1.47s system 20% cpu 10.060 total
After:
pwn shellcraft i386.linux.sh 0.42s user 0.27s system 25% cpu 2.722 total
This also has the side-effect of allowing e.g.
shellcraft amd64.open
which mimics the in-Python behavior:Fixes #1650