Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python2 shebangs where appropriate #1692

Merged
merged 2 commits into from
Oct 5, 2020

Conversation

mariuszskon
Copy link
Contributor

Closes #1404
All non-scripts have had the shebang removed.
Other than the pwnlib/commandline directory, these scripts were found (so the shebang was not removed):

pwnlib/data/useragents/download-useragents.py
pwnlib/data/syscalls/generate.py

The empty files mentioned in #1404 appear to be used. __doc__ files in shellcraft are used in

with open(os.path.join(self._absdir, "__doc__")) as fd:

pwnlib/encoders/arm/alphanumeric/alphanumeric.py is indirectly imported through
from pwnlib.encoders.encoder import alphanumeric

This means the empty files were not removed.

@mariuszskon
Copy link
Contributor Author

Hmm, the coveralls output seems to have suddenly started considering the scripts so the coverage delta is relatively large, but I think it's a false positive.

I'm not sure what the PyLint errors are 😬

@Arusekk
Copy link
Member

Arusekk commented Oct 5, 2020

Easy, the pylint errors are due to line number changes (the simple line diff is not so great), especially that your changes are near the beginning.

@Arusekk Arusekk merged commit 1d6aa2e into Gallopsled:dev Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues identified while packaging pwntools
2 participants