Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cache directories #1757

Merged
merged 2 commits into from
Jan 5, 2021
Merged

update cache directories #1757

merged 2 commits into from
Jan 5, 2021

Conversation

152334H
Copy link
Contributor

@152334H 152334H commented Jan 4, 2021

Please provide a high-level explanation of what this pull request is for.

Pwntools uses ~/.cache/.pwntools-cache* now, not ~/.pwntools-cache?

After creating your Pull Request, please add and push a commit that updates the changelog for the appropriate branch.

Doing PR to verify that I'm not missing something obvious

@Arusekk Arusekk merged commit 2f4c5cb into Gallopsled:dev Jan 5, 2021
@zachriggle
Copy link
Member

This will cause everybody who put never in the update file to have to re-do that step 😢

@152334H
Copy link
Contributor Author

152334H commented Jan 14, 2021

Will it? It was my impression that people using ~/.pwntools-cache-* already had life broken for them...

@zachriggle
Copy link
Member

Putting the "disable" file inside of the pwntools CACHE directory was probably a bad move in the first place.

I must have missed that change :(

@Arusekk
Copy link
Member

Arusekk commented Jan 14, 2021

This change is reflecting in the documentation what was already present from #1420 and before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants