Defer import of requests and urllib #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This saves 100ms-150ms of startup time on "from pwn import *"
heapcrash
force-pushed
the
defer-requests-and-urllib
branch
from
fd4f940 to
37b5e42
Compare
|
Re: #1687 |
|
Are there any docs that state we auto-import requests?
On Tue, Jun 1, 2021 at 4:00 PM peace-maker ***@***.***> wrote:
Re: #1687 <#1687>
We should change the docs in this case.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#1906 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APYTIFKF5WDLUGY65U2F65TTQVC67ANCNFSM45Z6VMTA>
.
--
*Heap Crash (Twitter <https://twitter.com/heapcrash>, GitHub
<http://github.com/heapcrash>)*
|
|
Yes, that's why it was added to toplevel imports in that PR. https://github.com/Gallopsled/pwntools/blame/dev/docs/source/globals.rst#L100 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves 100ms-150ms of startup time on "from pwn import *"