gdb.debug: avoid 2s timeout if possible #2435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Ubuntu 22.04 gdb.debug() takes at least 2 seconds. This is because it prints only "Remote debugging from host 127.0.0.1, port 33398", but the code expects 2 lines. It's very unclear what the second line is supposed to be; the only lead is "* Handle extra newline printed by gdb" in commit 338fbeb ("Improve pwnup template, gdbserver detection (Gallopsled#1148)"), but I could not trace it back to the GDB source code, both historic and modern. Perhaps, there is a non-upstreamed patch in some distro that introduces it. It should still be safe to skip waiting for the second line if the first one already starts with "Remote debugging ...", so do it.
peace-maker
approved these changes
Aug 5, 2024
k4lizen
pushed a commit
to k4lizen/pwntools
that referenced
this pull request
Aug 6, 2024
On Ubuntu 22.04 gdb.debug() takes at least 2 seconds. This is because it prints only "Remote debugging from host 127.0.0.1, port 33398", but the code expects 2 lines. It's very unclear what the second line is supposed to be; the only lead is "* Handle extra newline printed by gdb" in commit 338fbeb ("Improve pwnup template, gdbserver detection (Gallopsled#1148)"), but I could not trace it back to the GDB source code, both historic and modern. Perhaps, there is a non-upstreamed patch in some distro that introduces it. It should still be safe to skip waiting for the second line if the first one already starts with "Remote debugging ...", so do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Ubuntu 22.04 gdb.debug() takes at least 2 seconds. This is because it prints only "Remote debugging from host 127.0.0.1, port 33398", but the code expects 2 lines.
It's very unclear what the second line is supposed to be; the only lead is "* Handle extra newline printed by gdb" in commit 338fbeb ("Improve pwnup template, gdbserver detection (#1148)"), but I could not trace it back to the GDB source code, both historic and modern. Perhaps, there is a non-upstreamed patch in some distro that introduces it.
It should still be safe to skip waiting for the second line if the first one already starts with "Remote debugging ...", so do it.