Primitive scanl #1303
Merged
Primitive scanl #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianhuffman
approved these changes
Nov 23, 2021
There was a problem hiding this comment.
It would be good to have something in the test suite that checks, for both concrete and symbolic evaluation, that the implementations of foldl and scanl match the behavior specified by their original definitions. (Actually, we should have such tests for all primitives—see #48—but we can start by making tests for new primitives as we add them.)
in the prelude to use `foldr` or `scanl`. This leaves `sortBy` as the only remaining operation in the Cryptol prelude defined directly by recursion.
It is convenient for Coq extraction for the constant 1 factor to be on the left of the addition symbol.
`scanl` and `iterate` to their primitive implementations.
robdockins
force-pushed
the
primitive-scanl
branch
from
5484a95
to
928cc98
Compare
This speeds up concrete computation and preserves sharing for symbolic computation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
scanlto a primitive instead of a defined value in the Prelude. In addition, a few other definitions in the Prelude were reimplemented to usefoldlorscanlinstead of being directly recursive.These changes are primarily intended to support the Cryptol->Coq extraction use case in SAW. That extraction currently has no way to translate recursive Cryptol programs, so it is useful to avoid them for basic functionality exposed via the Prelude. With this PR the
sortByfunction is the only remaining recursive definition in the Prelude.