-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1691 (and removes partial match warning) #1692
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, aside from some minor spelling and style suggestions.
NormalName -> ModName m AnonModArgName | ||
AnonModArgName -> panic "modNameArg" ["Name is not normal"] | ||
AnonIfaceModName -> panic "modNameArg" ["Name is not normal"] | ||
NormalName -> ModName m AnonModArgName | ||
_ -> panic "modNameArg" ["Name is not normal"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generally prefer enumerating the data constructors instead of using a wildcard pattern, as this makes it harder to forget this code later if we ever change the definition of MaybeAnon
. I'll defer to your judgment on which is better, however.
AnonModArgName -> panic "modNameIfaceMod" ["Name is not normal"] | ||
AnonIfaceModName -> panic "modNameIfaceMod" ["Name is not normal"] | ||
_ -> panic "modNameIfaceMod" ["Name is not normal"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A similar comment about wildcard patterns here.
Also, there is a test suite failure on Windows:
|
Co-authored-by: Ryan Scott <rscott@galois.com>
Co-authored-by: Ryan Scott <rscott@galois.com>
# Conflicts: # CHANGES.md
No description provided.