Update type of take in book
#1748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marsella
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
Looks entirely reasonable to me. @yav, do we have a policy of needing to regenerate the PDF copy of the book that is checked into version control whenever the book's source is updated? |
marsella
temporarily deployed
to
github-pages
GitHub Actions
Inactive
RyanGlScott
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1747.
I looked through all the other instances of
takein the book. The other place with the type signature is correct (allows infinite front) and there are no examples or anything that claim that infinite fronts are disallowed. Also, all the other sequence types are correct.