Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prime to isNumeric, define cryPrime SMT-LIB function #1778

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Add prime to isNumeric, define cryPrime SMT-LIB function #1778

merged 3 commits into from
Nov 27, 2024

Conversation

RyanGlScott
Copy link
Contributor

Fixes #1777.

@RyanGlScott RyanGlScott requested a review from yav November 27, 2024 18:58
yav
yav reviewed Nov 27, 2024
View reviewed changes
lib/CryptolTC.z3 Outdated Show resolved Hide resolved
@RyanGlScott
CryptolTC.z3: Don't bother defining a prime table
f8dffb9 
`prime` is usually called on large primes, so it's not worth the effort of
defining a lookup table for small prime numbers. Either way, this is unlikely
to have a noticeable effect on performance.
@RyanGlScott RyanGlScott merged commit 9a53006 into master Nov 27, 2024
49 checks passed
@RyanGlScott RyanGlScott deleted the T1777-isNumeric-prime branch November 27, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yav yav yav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make isNumeric include prime constraints
2 participants
@RyanGlScott @yav