Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small improvements to test_reopt_with_relink.sh #203

Merged
merged 1 commit into from
Oct 7, 2024
Merged

small improvements to test_reopt_with_relink.sh #203

merged 1 commit into from
Oct 7, 2024

Conversation

Ptival
Copy link
Contributor

@Ptival Ptival commented Aug 18, 2022

No description provided.

@Ptival Ptival force-pushed the vr/improve-test_reopt_with_relink.sh branch from bb5e18c to cbbc174 Compare June 16, 2023 18:02
RyanGlScott
RyanGlScott approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admittedly, I've never run this script before, but these changes look straightforward.

kquick
kquick reviewed Jun 20, 2023
View reviewed changes
Copy link
Member

@kquick kquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, using #!/usr/bin/env bash is usually preferred to #!/bin/bash

@Ptival Ptival force-pushed the vr/improve-test_reopt_with_relink.sh branch from cbbc174 to 7d0fff0 Compare October 7, 2024 23:19
@Ptival Ptival merged commit 0d39383 into main Oct 7, 2024
2 checks passed
@Ptival Ptival deleted the vr/improve-test_reopt_with_relink.sh branch October 7, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kquick kquick kquick left review comments

@RyanGlScott RyanGlScott RyanGlScott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ptival @kquick @RyanGlScott