-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump submodules. #2011
Bump submodules. #2011
Conversation
Some integration tests are failing due to some files moving around a bit in GaloisInc/cryptol-specs#67, e.g.,
That is likely failing since |
examples/aes/aes.saw
Outdated
@@ -1,3 +1,4 @@ | |||
import "../../deps/cryptol-specs/Common/GF28.cry"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RyanGlScott @qsctr is this expected? This is the error without the explicit import:
Cryptol error:
Error: Could not find module Common::GF28
Searched paths:
../../deps/cryptol-specs/Primitive/Symmetric/Cipher/Block
/home/runner/work/saw-script/saw-script/dist/lib
/home/runner/work/saw-script/saw-script/examples/aes
/home/runner/work/saw-script/saw-script/intTests/.cryptol
/home/runner/work/saw-script/saw-script/dist/share/cryptol
Set the CRYPTOLPATH environment variable to search more directories
it seems that the issue is that Common::GF28
is relative to Primitive::Symmetric::Cipher::Block::AES
, not absolute, I'm not sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GaloisInc/cryptol-specs#67 moved the location of Common::GF28
within the cryptol-specs
repo. Previously, it was located at Primitive/Symmetric/Cipher/Block/AES/GF28.cry
, so the import "../../deps/cryptol-specs/Primitive/Symmetric/Cipher/Block/AES.cry"
line would be enough to find it. After GaloisInc/cryptol-specs#67, however, Common::GF28
is now located at Common/GF28.cry
(it is now used by other things in cryptol-specs
besides AES), so you have to explicitly indicate this.
This reverts commit b7ef1a1.
I'm splitting the cryptol-specs bump, as it causes a timeout in |
No description provided.