feat: added totp login #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+31
to
+33
| std::io::stdin() | ||
| .read_line(&mut input) | ||
| .expect("Failed to read line"); |
There was a problem hiding this comment.
What are the guarantees that this operation can never fail ?
|
Was wondering if we can e2e test this out. |
yup, but this require lib so that we can generate totp code. will look how we can do It. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage:
If TOTP is required but not provided, the user will be prompted to input it. If the entered code is incorrect, it will repeatedly ask for the correct code (loop).
If TOTP is required and the user has already passed the login code via --two-fa-code, this code will be used. If this code is incorrect, it will again prompt for the correct code (loop input).