Auto-set display currency for level 1 users based on phone number prefix #4271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prakhar-Agarwal-byte
force-pushed
the
def_cur
branch
from
475ff81 to
ae47753
Compare
Prakhar-Agarwal-byte
changed the title
dolcalmi
requested changes
Apr 9, 2024
| // Set display currency to match phone numbers country code | ||
| const countryCode = (phoneMetadata?.countryCode || "US") as Countries | ||
| const currency = countryToCurrency[countryCode] | ||
| account.displayCurrency = currency as DisplayCurrency |
There was a problem hiding this comment.
we need to validate against our list of currencies (we dont support all the currencies)
Signed-off-by: Prakhar Agarwal <prakharagarwal3031@gmail.com>
|
@Prakhar-Agarwal-byte thanks for the contribution! I just updated the branch to remove some merge conflicts. Will you be continuing with this PR? There's some feedback from @dolcalmi to address |
|
Closing in favour of a different approach we took to tackle this in #4309 and GaloyMoney/price#67 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4252
Matches the
countryCodeinphoneMetadatareceived from Twilio with currency using country-to-currency package and then updates the default display currency for the new user