fix: convert string fees to number and use the min (#106)

Co-authored-by: Sebastien Verreault <sebver@pm.me>
GaloyMoney · Jun 19, 2022 · 9affef3 · 9affef3
1 parent 853c18d
commit 9affef3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/dealer/src/OkexExchange.ts b/dealer/src/OkexExchange.ts
@@ -434,11 +434,11 @@ export class OkexExchange extends ExchangeBase {
                 "exchange.privateGetAssetCurrencies() returned: {response}",
               )
               if (btcCurrency?.minWd)
-                config.minOnChainWithdrawalAmount = btcCurrency?.minWd
+                config.minOnChainWithdrawalAmount = Number(btcCurrency?.minWd)
               if (btcCurrency?.minFee)
-                config.minOnChainWithdrawalFee = btcCurrency?.minFee
+                config.minOnChainWithdrawalFee = Number(btcCurrency?.minFee)
               if (btcCurrency?.maxFee)
-                config.maxOnChainWithdrawalFee = btcCurrency?.maxFee
+                config.maxOnChainWithdrawalFee = Number(btcCurrency?.maxFee)
               this.logger.debug(
                 { config, response: btcCurrency },
                 "ExchangeConfiguration after update: {config}",

diff --git a/dealer/src/OkexPerpetualSwapStrategy.ts b/dealer/src/OkexPerpetualSwapStrategy.ts
@@ -526,11 +526,10 @@ export class OkexPerpetualSwapStrategy implements HedgingStrategy {
 
             // then initiate the withdrawal which by default uses the funding account
             const config = this.exchangeConfig as OkexExchangeConfiguration
-            const averageFee =
-              (config.minOnChainWithdrawalFee + config.maxOnChainWithdrawalFee) / 2
+            const averageFee = config.minOnChainWithdrawalFee
             const withdrawArgs = {
               currency: TradeCurrency.BTC,
-              quantity: transferSizeInBtc,
+              quantity: transferSizeInBtc - averageFee,
               address: withdrawOnChainAddress,
               params: {
                 fee: averageFee,