fix: set root for scheduler cron span

GaloyMoney · Jul 11, 2022 · ca9598f · ca9598f
1 parent b57212b
commit ca9598f
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 21 deletions.
diff --git a/dealer/src/app/dealer.ts b/dealer/src/app/dealer.ts
@@ -8,6 +8,7 @@ const main = async () => {
 
   const DealerUpdatePositionAndLeverageTask = () => dealer.updatePositionAndLeverage()
   const wrappedTask = wrapAsyncToRunInSpan({
+    root: true,
     namespace: "app.dealer",
     fn: DealerUpdatePositionAndLeverageTask,
   })

diff --git a/dealer/src/app/scheduler.ts b/dealer/src/app/scheduler.ts
@@ -2,29 +2,26 @@ import cron from "node-cron"
 
 import { baseLogger } from "../services/logger"
 import { Dealer } from "../Dealer"
-import { recordExceptionInCurrentSpan, wrapAsyncToRunInSpan } from "../services/tracing"
-import { ErrorLevel } from "../Result"
+import { wrapAsyncToRunInSpan } from "../services/tracing"
 
 const logger = baseLogger.child({ module: "cron" })
 
 export async function scheduler() {
-  cron.schedule("0,5,10,15,20,25,30,35,40,45,50,55 * * * *", async () => {
-    try {
-      const dealer = new Dealer(logger)
-      logger.info("Starting Dealer via Scheduler")
-      const DealerUpdatePositionAndLeverageTask = () => dealer.updatePositionAndLeverage()
-      const wrappedTask = wrapAsyncToRunInSpan({
-        namespace: "app.scheduler",
-        fn: DealerUpdatePositionAndLeverageTask,
-      })
-      const result = await wrappedTask()
-      baseLogger.info(
-        { result },
-        `dealer.updatePositionAndLeverage() returned: ${result}`,
-      )
-    } catch (error) {
-      recordExceptionInCurrentSpan({ error, level: ErrorLevel.Warn })
-      baseLogger.warn(`Error in Scheduler job: ${error}`)
-    }
-  })
+  cron.schedule("0,5,10,15,20,25,30,35,40,45,50,55 * * * *", wrapAsyncToRunInSpan({
+    root: true,
+    namespace: "app.scheduler",
+    fnName: "run",
+    fn: async () => {
+      try {
+        logger.info("Starting Dealer via Scheduler")
+
+        const dealer = new Dealer(logger)
+        const result = await dealer.updatePositionAndLeverage()
+
+        baseLogger.info({ result }, `Update position and leverage result`)
+      } catch (error) {
+        baseLogger.warn({error}, "Error in Scheduler job")
+      }
+    },
+  }))
 }