Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/physx 4.0 #258

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

webhaikal
Copy link

This PR solves #252. Update PhysX from 3.3 to 4.0, CMake is updated to reflect this but as I'm not familiar with CMake, it might have some errors.

Following on above, you would need to add another value to C++/C->Preprocessor or equivalent the following item:
PX_PHYSX_CHARACTER_STATIC_LIB
to avoid linking errors.

I've tested it using the bsfExamples but couldn't make the ball spawn, so I can't test rigidbodies. So you can treat this as WIP. You may also revert commit webhaikal/bsf@318fe28

Signed-off-by: Haikal Izzuddin <haikalizz05@gmail.com>
Changes made:
* PxConvexFlag::eINFLATE_CONVEX is removed in 4.0, suggest to find other way around
* Not sure line 235 on BsPhysX.cpp does, commented it since we're no longer using the old pair.contactStream
* PxSceneQueryHitType is renamed to PxQueryHitType

Signed-off-by: Haikal Izzuddin <haikalizz05@gmail.com>
Signed-off-by: Haikal Izzuddin <haikalizz05@gmail.com>
@BearishSun
Copy link
Member

Thank you. Since this requires me to compile PhysX4 on all platforms, it will take longer than usual to merge, until I get a moment to do so. Let me know when you feel everything is functional on Windows and I'll see about merging.

I believe the stuff in CMakeFiles folder was added in error? Could you remove it from the PR?
Why is the documentation download commented out? In any case, it shouldn't be part of the PR.
I notice the event callback is commented out. Is there a replacement mechanism for this?
What's the issue with eINFLATE_CONVEX?

@webhaikal
Copy link
Author

The CMakeFiles & Documentation part was added in by error. Will revert it back. However, you would need to update the FindPhysx CMake file to account for the new naming scheme.

Event Callback was commented out as I am not sure how to implement but will update it around today.

eINFLATE_CONVEX is removed from PhysX 4 as the new algorithm doesn't need to have it inflated.

@BearishSun
Copy link
Member

Sounds good.

Signed-off-by: Haikal Izzuddin <haikalizz05@gmail.com>
Signed-off-by: Haikal Izzuddin <haikalizz05@gmail.com>
@webhaikal
Copy link
Author

Sounds good.

There you go, everything is done, reverted back the documentation comments and updated FindPhysX to reflect new naming scheme. Everything should be functional, just the extra preprocessor flag is needed for bsPhysx PX_PHYSX_CHARACTER_STATIC_LIB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants