Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sets default symbol visibility to hidden. Resolves #74 #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Sets default symbol visibility to hidden. Resolves #74 #75

wants to merge 1 commit into from

Conversation

jonesmz
Copy link
Contributor

@jonesmz jonesmz commented Apr 1, 2018

No description provided.

@BearishSun
Copy link
Member

This fails on Windows because the thread-local stuff isn't allowed to be dll exported:

c:\projects\bsf\source\foundation\bsfutility\allocators\bsmemoryallocator.h(125): error C2492: 'bs::MemoryCounter::Frees': data with thread storage duration may not have dll interface (compiling source file C:\Projects\bsf\Source\Foundation\bsfCore\Scene\BsPrefab.cpp) [C:\Projects\bsf\Build\Source\Foundation\bsf.vcxproj]

@jonesmz
Copy link
Contributor Author

jonesmz commented Apr 1, 2018

Hrmm, so the difficulty here is that with gcc, unless I export the entire class, it won't link. Apparently they don't support exporting individual member functions.

Would you be OK with a conditional compile? Export the whole class with gcc, export only the functions with msvc ?

@BearishSun
Copy link
Member

Yep, that sounds fine.

@jonesmz jonesmz force-pushed the visibility_hidden branch 5 times, most recently from 14ab0d0 to 5323443 Compare April 10, 2018 18:53
@jonesmz jonesmz force-pushed the visibility_hidden branch 2 times, most recently from 073d053 to aea7c1d Compare May 13, 2018 06:55
@jonesmz jonesmz force-pushed the visibility_hidden branch 2 times, most recently from c03d4bb to 11e1ee4 Compare May 16, 2018 20:00
@jonesmz
Copy link
Contributor Author

jonesmz commented Jul 9, 2018

Sorry for the long delay on this issue. Busy with other stuff shrug. Still planning to provide a patch as described.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonesmz @BearishSun