Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nfd update #2286

Merged
merged 6 commits into from
Feb 2, 2019
Merged

Nfd update #2286

merged 6 commits into from
Feb 2, 2019

Conversation

Azaezel
Copy link
Contributor

@Azaezel Azaezel commented Jan 1, 2019

No description provided.

…s. likely need to do the same on mac and potentially resolve conflicts on linux
… folks have a chance to beat up the zenity one.
@Areloch
Copy link
Contributor

Areloch commented Jan 6, 2019

With the default settings, looks to work fine on Ubuntu, no issues noted.
Also looks to work fine in Win. Need to test on the mac before merge-in to be sure it's all kosher(And give a run of the zenity mode to ensure that plays nice as at least an alternate mode)

@jmdejong
Copy link
Contributor

jmdejong commented Jan 6, 2019

I think you need to add nfd_gtk.c to the blacklist when using zenity, otherwise it will just run gtk anyways.

There's a few bugs in nfd zenity:

char* prefix = "--filename";

This should be char* prefix = "--filename="; instead. See also mlabbe/nativefiledialog#60

release_assert(waitpid(pid, &status, 0) == pid);

waitpid will always error (return -1) when the handler for SIGCHLD is set to SIG_IGN (which is the default).
https://stackoverflow.com/questions/22681021/waitpid-with-execl-used-in-child-returns-1-with-echild/24599676#24599676
This can be fixed by setting an empty handler for SIGCHLD.
See mlabbe/nativefiledialog#61 for my proposed solution.
Alternatively the assertion could be removed.

@Areloch Areloch merged commit 489689a into GarageGames:development Feb 2, 2019
@Azaezel Azaezel deleted the NFD_Update branch August 22, 2019 09:26
Areloch added a commit to Areloch/GG-Torque3D that referenced this pull request Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants