-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nfd update #2286
Merged
Merged
Nfd update #2286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s. likely need to do the same on mac and potentially resolve conflicts on linux
… folks have a chance to beat up the zenity one.
With the default settings, looks to work fine on Ubuntu, no issues noted. |
I think you need to add nfd_gtk.c to the blacklist when using zenity, otherwise it will just run gtk anyways. There's a few bugs in nfd zenity:
This should be char* prefix = "--filename="; instead. See also mlabbe/nativefiledialog#60
waitpid will always error (return -1) when the handler for SIGCHLD is set to SIG_IGN (which is the default). https://stackoverflow.com/questions/22681021/waitpid-with-execl-used-in-child-returns-1-with-echild/24599676#24599676 This can be fixed by setting an empty handler for SIGCHLD. See mlabbe/nativefiledialog#61 for my proposed solution. Alternatively the assertion could be removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.