Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#222 Load Model Without Predict #239

Merged
merged 2 commits into from
Jul 27, 2023
Merged

#222 Load Model Without Predict #239

merged 2 commits into from
Jul 27, 2023

Conversation

adaem2
Copy link
Contributor

@adaem2 adaem2 commented Jul 26, 2023

Link to any related issues, companion PRs, or blockers. eg, Fixes #37
#222

Overview

A user is able to access the loaded model from S3 by calling model.model.

Discussion

Any additional context that you think is important for reviewers or future users/contributors looking at this PR.
The issue originated from issue #200. Currently cannot replicate loading the model locally due to issues in dependencies with the required pyyaml version of ml-mast and cython.
yaml/pyyaml#724
yaml/pyyaml#728

Testing

Testing it through a pipeline as well as by trying to create a _Model object through the Model function and a registered model's name. In testing just obtaining the model, you need to obtain a presigned_url_response with client.backend_client.get_model_download_urls([model's name])

Documentation

Does this PR update any docs pages? Should it?


📚 Documentation preview 📚: https://garden-ai--239.org.readthedocs.build/en/239/

@codecov-commenter
Copy link

Codecov Report

Merging #239 (b17856f) into main (997fbbf) will increase coverage by 0.65%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
+ Coverage   77.83%   78.48%   +0.65%     
==========================================
  Files          46       46              
  Lines        3113     3124      +11     
==========================================
+ Hits         2423     2452      +29     
+ Misses        690      672      -18     
Files Changed Coverage Δ
garden_ai/_model.py 48.05% <100.00%> (+26.43%) ⬆️
tests/test_mlmodel.py 100.00% <100.00%> (ø)

Copy link
Collaborator

@WillEngler WillEngler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, no notes.

@adaem2 adaem2 merged commit e8bbf9c into main Jul 27, 2023
7 checks passed
@adaem2 adaem2 deleted the 222-get-model branch July 27, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants