Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in CSS and All Routes of Navbar and Login Css also #999

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+458 −854
Open

Changes in CSS and All Routes of Navbar and Login Css also #999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb70d91
changes in css and all routes of navbar
subodhkangale07 Nov 6, 2024
bf36a97
Merge branch 'main' into Subodh
subodhkangale07 Nov 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions RateMyResume.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@
<body>
<!-- header section starts -->
<header>
<a href="#" class="logo">Resum Resume<span>.</span></a>
<a href="/" class="logo">Resum Resume<span>.</span></a>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

⚠️ Potential issue

Navigation patterns need standardization across the application

The verification reveals inconsistent navigation patterns throughout the application:

  1. The logo link "/" is used consistently across main pages (index.html, resume.html, RateMyResume.html, about.html) but Faqs.html uses "#"
  2. Email icon links are inconsistent:
    • RateMyResume.html: href="/"
    • Faqs.html: href="#"
  3. Mixed patterns for same destinations:
    • Home links use both "/" and "index.html"
    • Some pages use relative paths (about.html, resume.html) while others use root paths
  4. Footer links vary between "/" and "#" for identical sections

Suggested standardization:

- <a href="/" class="logo">Resum Resume<span>.</span></a>
+ <a href="/home">Resum Resume<span>.</span></a>

- <a href="/">Home</a>
+ <a href="/home">Home</a>

- <a href="/" class="fas fa-envelope"></a>
+ <a href="mailto:contact@resumresume.com" class="fas fa-envelope"></a>
🔗 Analysis chain

Review and standardize navigation patterns

Several issues with the navigation implementation:

  1. Multiple links pointing to "/" without specific destinations
  2. Inconsistent URL patterns (mixing relative paths like "about.html" with root paths "/")
  3. Email icon incorrectly links to root path instead of providing email functionality

Consider these improvements:

- <a href="/" class="logo">Resum Resume<span>.</span></a>
+ <a href="/home" class="logo">Resum Resume<span>.</span></a>

- <a href="/">Home</a>
+ <a href="/home">Home</a>

- <a href="/" class="fas fa-envelope"></a>
+ <a href="mailto:contact@resumresume.com" class="fas fa-envelope"></a>

Let's verify the navigation patterns across other pages:

Also applies to: 17-22, 27-29

Let me search for specific navigation patterns to better understand the current implementation and verify the concerns raised in the review comment.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for inconsistent navigation patterns
rg -l 'href="/' --type html
rg -l 'href="[^/].*\.html"' --type html

Length of output: 2577

Script:

#!/bin/bash
# Search for navigation patterns more thoroughly
rg -A 2 'href="/' --type html
rg -A 2 'href="[^/].*\.html"' --type html
rg -A 2 '<a.*class="logo"' --type html
rg -A 2 '<a.*class="fas fa-envelope"' --type html

Length of output: 15215


<nav class="navbar">
<a href="#home">Home</a>
<a href="/">Home</a>
<a href="about.html">About</a>
<a href="resume.html">Build Resume</a>
<a href="RateMyResume.html">RateMyResume</a>
Expand All @@ -24,7 +24,7 @@

<div class="icons">
<a href="about.html" class="fas fa-info-circle"></a>
<a href="#" class="fas fa-envelope"></a>
<a href="/" class="fas fa-envelope"></a>
<a href="login.html" id="loginIcon" class="fas fa-user"></a>
<i class="fa-solid fa-coins"></i> <p id="SkillCoins"></p>
</div>
Expand Down Expand Up @@ -185,34 +185,34 @@ <h2>Relevant Keywords for Your Resume</h2>
<div class="footer-section">
<h3>About Us</h3>
<ul>
<li><a href="#">Our Story</a></li>
<li><a href="#">Team</a></li>
<li><a href="#">Careers</a></li>
<li><a href="/">Our Story</a></li>
<li><a href="/">Team</a></li>
<li><a href="/">Careers</a></li>
</ul>
</div>
<div class="footer-section">
<h3>Services</h3>
<ul>
<li><a href="#">Resume Builder</a></li>
<li><a href="/">Resume Builder</a></li>
<li><a href="cv.html">CV Templates</a></li>
<li><a href="#">Career Advice</a></li>
<li><a href="/">Career Advice</a></li>
</ul>
</div>
<div class="footer-section">
<h3>Support</h3>
<ul>
<li><a href="#">FAQ</a></li>
<li><a href="#">Contact Us</a></li>
<li><a href="#">Privacy Policy</a></li>
<li><a href="/">FAQ</a></li>
<li><a href="/">Contact Us</a></li>
<li><a href="/">Privacy Policy</a></li>
</ul>
</div>
<div class="footer-section">
<h3>Connect With Us</h3>
<div class="social-icons">
<a href="#"><i class="fab fa-facebook-f"></i></a>
<a href="#"><i class="fab fa-twitter"></i></a>
<a href="#"><i class="fab fa-linkedin-in"></i></a>
<a href="#"><i class="fab fa-instagram"></i></a>
<a href="/"><i class="fab fa-facebook-f"></i></a>
<a href="/"><i class="fab fa-twitter"></i></a>
<a href="/"><i class="fab fa-linkedin-in"></i></a>
<a href="/"><i class="fab fa-instagram"></i></a>
</div>
</div>
</div>
Expand Down
143 changes: 34 additions & 109 deletions Resume.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,134 +382,59 @@ button:focus {
text-align: center;
width: 25%;
cursor: pointer;
transition: transform 0.3s, box-shadow 0.3s; /* Added box-shadow transition */
transition: transform 0.3s, box-shadow 0.3s; /* Added transition for scaling effect */
}

.template-card:hover {
transform: scale(1.05);
box-shadow: 0 4px 15px rgba(0, 0, 0, 0.2); /* Added shadow on hover */
transform: scale(1.05); /* Added scaling effect on hover */
box-shadow: 0 4px 8px rgba(0, 0, 0, 0.2);
}

.template-card img {
max-width: 100%;
height: auto;
margin-bottom: 10px;
.template-image {
width: 100%;
height: 150px;
object-fit: cover;
border-radius: 8px;
}
.template-card p{

.template-name {
font-size: 1.5rem;
font-weight: 500;
margin-top: 1rem;
color: black;
color: #333;
margin-top: 10px;
}
.buttons {
margin-top: 20px;
display: flex;
justify-content: space-between;

.template-card.selected {
border-color: #007bff;
}

.buttons button {
padding: 10px 20px;
.submit-section {
display: flex;
justify-content: center;
margin-top: 30px;
}
.submit-button {
font-size: 1.5rem;
padding: 15px 40px;
background-color: #007bff;
color: white;
border: none;
border-radius: 5px;
cursor: pointer;
}

.buttons button:hover {
.submit-button:hover {
background-color: #0056b3;
}
.step1btns{
display: flex;
justify-content: right;
}
.premium{
margin-top: 1rem;
display: flex;
justify-content: space-between;
}
#coinicon{
display: flex;
justify-content: center;
align-items: center;
gap: 4px;
}
#coinicon p{
font-size: 2rem;
margin: 0;
}
.fa-coins{
font-size: 2rem;
color: rgb(246, 180, 0);
}
/* Step 3 Styles */
#step-3{
width: 90%;
margin: auto;
background: #f4f4f4;
padding: 20px;
border-radius: 8px;
box-shadow: 0 0 10px rgba(0,0,0,0.1);
}
.step-section {
padding: 20px;
border: 1px solid #ccc;
border-radius: 8px;
background-color: #f9f9f9;
margin-top: 20px;
}

#resume-display {
margin-top: 20px;
padding: 10px;
border: 1px solid #ddd;
border-radius: 8px;
background-color: #fff;
}

#resume-display h1 {
font-size: 2em;
margin-bottom: 10px;
}

#resume-display h2 {
font-size: 1.5em;
margin: 15px 0 5px;
.submit-button:disabled {
background-color: #ccc;
cursor: not-allowed;
}

#resume-display h3 {
font-size: 1.2em;
margin: 10px 0 5px;
}

#resume-display p {
margin: 5px 0;
.template-image-container {
max-height: 150px; /* Set a fixed maximum height for the image */
overflow: hidden; /* Hide any overflowing content */
border-radius: 8px; /* Add a border radius for rounded corners */
}

/* Button Styles */
button {
margin: 10px 5px;
padding: 10px 15px;
font-size: 1em;
border: none;
border-radius: 5px;
cursor: pointer;
}

#prev-step-3 {
background-color: #f0ad4e; /* Bootstrap warning color */
color: white;
}

#download-resume {
background-color: #5cb85c; /* Bootstrap success color */
color: white;
h4{
color: #333;
font-weight: 400;
}
.ui-autocomplete {
max-height: 150px;
overflow-y: auto;
overflow-x: hidden;
border: 1px solid #ddd;
background-color: #fff;
}

30 changes: 15 additions & 15 deletions about.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,10 +470,10 @@
<header>
<!-- <input type="checkbox" name="" id="toggler">
<label for="toggler" class="fas fa-bars"></label> -->
<a href="#" class="logo">Resum Resume<span>.</span></a>
<a href="/" class="logo">Resum Resume<span>.</span></a>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Maintain consistent routing approach

The navigation links use inconsistent URL formats:

  • Home link uses absolute path "/"
  • About and Resume links use relative paths "about.html" and "resume.html"

This inconsistency could cause navigation issues. Consider using absolute paths consistently.

Apply this diff to maintain consistency:

        <a href="/" class="logo">Resum Resume<span>.</span></a>

        <nav class="navbar">
            <a href="/">Home</a>
-           <a href="about.html">About</a>
-           <a href="resume.html">Build Resume</a>
+           <a href="/about">About</a>
+           <a href="/resume">Build Resume</a>

Also applies to: 476-479


<nav class="navbar">
<a href="#home">Home</a>
<a href="/">Home</a>
<a href="about.html">About</a>
<a href="resume.html">Build Resume</a>
<!-- <a href="signup.html">Sign Up</a> -->
Expand Down Expand Up @@ -502,7 +502,7 @@
</header>
<nav class="mobile-navbar">
<div class="main-links">
<a href="#home">Home</a>
<a href="/">Home</a>
<a href="about.html">About</a>
<a href="resume.html">Build Resume</a>
Comment on lines +505 to 507
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Apply consistent routing in mobile navigation

The mobile navigation links have the same inconsistency as the main navigation.

Apply this diff to maintain consistency:

-           <a href="/">Home</a>
-           <a href="about.html">About</a>
-           <a href="resume.html">Build Resume</a>
+           <a href="/">Home</a>
+           <a href="/about">About</a>
+           <a href="/resume">Build Resume</a>
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<a href="/">Home</a>
<a href="about.html">About</a>
<a href="resume.html">Build Resume</a>
<a href="/">Home</a>
<a href="/about">About</a>
<a href="/resume">Build Resume</a>

</div>
Expand Down Expand Up @@ -610,34 +610,34 @@ <h2>Why Choose Us?</h2>
<div class="footer-section">
<h3>About Us</h3>
<ul class="ul">
<li><a href="#">Our Story</a></li>
<li><a href="#">Team</a></li>
<li><a href="#">Careers</a></li>
<li><a href="/">Our Story</a></li>
<li><a href="/">Team</a></li>
<li><a href="/">Careers</a></li>
Comment on lines +613 to +615
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Implement proper routing for footer links

Footer links currently point to "/" which is incorrect. Each link should point to its respective page.

Apply this diff to implement proper routing:

-                    <li><a href="/">Our Story</a></li>
-                    <li><a href="/">Team</a></li>
-                    <li><a href="/">Careers</a></li>
+                    <li><a href="/about/story">Our Story</a></li>
+                    <li><a href="/about/team">Team</a></li>
+                    <li><a href="/careers">Careers</a></li>

-                    <li><a href="/">Resume Builder</a></li>
-                    <li><a href="/">CV Templates</a></li>
-                    <li><a href="/">Career Advice</a></li>
+                    <li><a href="/resume">Resume Builder</a></li>
+                    <li><a href="/templates">CV Templates</a></li>
+                    <li><a href="/career-advice">Career Advice</a></li>

-                    <li><a href="/">FAQ</a></li>
-                    <li><a href="/">Contact Us</a></li>
+                    <li><a href="/faq">FAQ</a></li>
+                    <li><a href="/contact">Contact Us</a></li>

Also applies to: 621-623, 629-630

</ul>
</div>
<div class="footer-section">
<h3>Services</h3>
<ul class="ul">
<li><a href="#">Resume Builder</a></li>
<li><a href="#">CV Templates</a></li>
<li><a href="#">Career Advice</a></li>
<li><a href="/">Resume Builder</a></li>
<li><a href="/">CV Templates</a></li>
<li><a href="/">Career Advice</a></li>
</ul>
</div>
<div class="footer-section">
<h3>Support</h3>
<ul class="ul">
<li><a href="#">FAQ</a></li>
<li><a href="#">Contact Us</a></li>
<li><a href="/">FAQ</a></li>
<li><a href="/">Contact Us</a></li>
<li><a href="privacypolicy.html">Privacy Policy</a></li>
</ul>
</div>
<div class="footer-section">
<h3>Connect With Us</h3>
<div class="social-icons">
<a href="#"><i class="fab fa-facebook-f"></i></a>
<a href="#"><i class="fab fa-x-twitter"></i></a>
<a href="#"><i class="fab fa-linkedin-in"></i></a>
<a href="#"><i class="fab fa-instagram"></i></a>
<a href="/"><i class="fab fa-facebook-f"></i></a>
<a href="/"><i class="fab fa-x-twitter"></i></a>
<a href="/"><i class="fab fa-linkedin-in"></i></a>
<a href="/"><i class="fab fa-instagram"></i></a>
Comment on lines +637 to +640
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix social media links

Social media links incorrectly point to "/". They should link to the respective social media profiles.

Apply this diff:

-                    <a href="/"><i class="fab fa-facebook-f"></i></a>
-                    <a href="/"><i class="fab fa-x-twitter"></i></a>
-                    <a href="/"><i class="fab fa-linkedin-in"></i></a>
-                    <a href="/"><i class="fab fa-instagram"></i></a>
+                    <a href="https://facebook.com/resumbuilder" target="_blank" rel="noopener noreferrer"><i class="fab fa-facebook-f"></i></a>
+                    <a href="https://twitter.com/resumbuilder" target="_blank" rel="noopener noreferrer"><i class="fab fa-x-twitter"></i></a>
+                    <a href="https://linkedin.com/company/resumbuilder" target="_blank" rel="noopener noreferrer"><i class="fab fa-linkedin-in"></i></a>
+                    <a href="https://instagram.com/resumbuilder" target="_blank" rel="noopener noreferrer"><i class="fab fa-instagram"></i></a>

Committable suggestion skipped: line range outside the PR's diff.

</div>
</div>
</div>
Expand Down
6 changes: 3 additions & 3 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -906,10 +906,10 @@
<header>
<!-- <input type="checkbox" name="" id="toggler">
<label for="toggler" class="fas fa-bars"></label> -->
<a href="#" class="logo">Resum Resume<span>.</span></a>
<a href="/" class="logo">Resum Resume<span>.</span></a>

<nav class="navbar">
<a href="#home">Home</a>
<a href="/">Home</a>
<a href="about.html">About</a>
<a href="resume.html">Build Resume</a>
<!-- <a href="signup.html">Sign Up</a> -->
Expand Down Expand Up @@ -938,7 +938,7 @@
</header>
<nav class="mobile-navbar">
<div class="main-links">
<a href="#home">Home</a>
<a href="/">Home</a>
<a href="about.html">About</a>
<a href="resume.html">Build Resume</a>
</div>
Expand Down
Loading