Regex may not always match the desired substring.

[timothyjensen]

The regex used in the replace() method may not always match the substring 'no-js':

genesis-js-no-js/includes/class-genesis-js-no-js.php

Line 63 in 7bc90e3

c = c.replace(/no-js/, 'js');

Say we have a body class of 'home alpha-plugin-no-js no-js', then the regex will match the first occurrence of 'no-js' and result in a body class of 'home alpha-plugin-js no-js'.

To avoid this, we can add the global flag to the regex, but that might conflict with other plugins. Another idea is to add a space so that the regex matches / no-js/ (with a preceding space). We could also create a more complex regex, but that might not be necessary.

[GaryJones]

The space won't match when the classname is the first class in the attribute value (i.e. has a " before it).

But you're right, this regex could be improved.

[GaryJones]

@timothyjensen

How about a regex of ([" ])no-js([" ]), and a replace of $1js$2?

[timothyjensen]

@GaryJones I tested that out on a demo site and it didn't seem to work for me, possibly because quotation marks don't occur in the search string.

How about (^|\s)(no-js)(?![^\s]) and replace with js (with a leading space)?

[timothyjensen]

[GaryJones]

Better yet, why don't we use document.body.classList to grab the classes as an array instead?

var c = document.body.classList;
c = c.remove('no-js');
c = c.add('js');
document.body.classList = c;

[timothyjensen]

Brilliant! That's much better than a complex regex.

[timothyjensen]

Could reduce a few bytes with:

var c = document.body.classList;
c.remove('no-js');
c.add('js');

[GaryJones]

@timothyjensen Feel free to checkout and give 70c2126 a go (or the rest of the develop branch, if you're running PHP 7.1+).

[timothyjensen]

Great, I just tested develop on PHP 7.1.4 with no issues.

[GaryJones]

https://github.com/GaryJones/genesis-js-no-js/releases/tag/3.0.0 and https://github.com/GaryJones/genesis-js-no-js/releases/tag/3.0.1 have now been released which contains the improvement from here.