Feat/pda #2
Merged
Feat/pda #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafagomes
requested changes
Nov 3, 2023
src/pda/PDA.ts
Outdated
There was a problem hiding this comment.
name files always lowecase.
src/pda/PDA.ts
Outdated
| */ | ||
| async getIssuedPDAs({ filter, order, skip, take }: PDAFilter) { | ||
| try { | ||
| return await this.sdk.issuedPDAs_query({ filter, order, skip, take }); | ||
| } catch (error: any) { | ||
| console.log(error); |
src/pda/PDA.ts
Outdated
| return (await this.sdk.issuedPDAsCount_query({ filter })).issuedPDAsCount; | ||
| } catch (error: any) { | ||
| throw new Error(error?.message); | ||
| error; |
test/pda.test.ts
Outdated
| expect(PDA?.dataAsset?.title).toEqual("test"); | ||
| }); | ||
| describe("PDA TESTING", () => { | ||
| // it( |
test/pda.test.ts
Outdated
| DEFAULT_TIMEOUT | ||
| ); | ||
|
|
||
| // it( |
NMCarv
requested changes
Nov 20, 2023
test/pda.test.ts
Outdated
| 'create pda', | ||
| async () => { | ||
| let obj = { | ||
| dataModelId: 'f4014d53-b30f-4490-9812-cea379a1b398', |
There was a problem hiding this comment.
Either make this an environment variable, or create a new data model on the test. Don't pass IDs directly
test/pda.test.ts
Outdated
Comment on lines
28
to
29
| type: UserIdentifierType.EMAIL, | ||
| value: 'sid', |
There was a problem hiding this comment.
Is this working? sid is not an email
test/pda.test.ts
Outdated
Comment on lines
45
to
47
| const { PDA } = await api.pda.getPDA( | ||
| '6bc1a11f-f91d-4361-9a22-5df8d1bf4dc8', | ||
| ); |
There was a problem hiding this comment.
Create a PDA and then try to get it by ID
rafagomes
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.