Feat/auth #5
Merged
Feat/auth #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafagomes
requested changes
Nov 10, 2023
src/auth/auth.ts
Outdated
| } | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
you can remove that one.
src/auth/auth.ts
Outdated
| * method. | ||
| * @returns the result of the `this.sdk.unregisterAuthMethod_mutation` method, which is awaited. | ||
| */ | ||
| async unregisterAuthMethod({ data, type }: { data: JSON; type: AuthType }) { |
There was a problem hiding this comment.
Ideally, instead of JSON, try to type this data.
src/auth/auth.ts
Outdated
| * @param - - `authId`: A string representing the ID of the authentication method to be migrated. | ||
| * @returns the result of the `migrateAuthMethod` mutation. | ||
| */ | ||
| async migrateAuthMethod({ |
There was a problem hiding this comment.
@NunoMartins21 Do we need that? What is this method?
There was a problem hiding this comment.
That's to migrate an alias from one user to another. It's ok to have it on the SDK
rafagomes
requested changes
Nov 21, 2023
src/auth/auth.ts
Outdated
| * @param {Chain} chain : a chain optional of type Chain | ||
| * @returns the result of the `createWalletNounce` method call, is a message which will be used to confirm wallet. | ||
| */ | ||
| async createWalletNounce({ |
There was a problem hiding this comment.
why the user needs to open an object for that? change all things like that to pass directly as params
src/auth/auth.ts
Outdated
| * @param - - `authId`: A string representing the ID of the authentication method to be migrated. | ||
| * @returns the result of the `migrateAuthMethod` mutation. | ||
| */ | ||
| async migrateAuthMethod({ |
NMCarv
requested changes
Nov 29, 2023
test/auth.test.ts
Outdated
| it( | ||
| 'create wallet nounce', | ||
| async () => { | ||
| const { message } = await api.auth.createWalletNounce( |
There was a problem hiding this comment.
Suggested change
| const { message } = await api.auth.createWalletNounce( | |
| const { message } = await api.auth.createWalletNonce( |
src/auth/auth.ts
Outdated
| * @param {Chain} chain : a chain optional of type Chain | ||
| * @returns the result of the `createWalletNounce` method call, is a message which will be used to confirm wallet. | ||
| */ | ||
| async createWalletNounce(wallet: string, chain?: Chain) { |
There was a problem hiding this comment.
Suggested change
| async createWalletNounce(wallet: string, chain?: Chain) { | |
| async createWalletNonce(wallet: string, chain?: Chain) { |
NMCarv
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added all methods related to Auth and possible unit test for it