Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profile editing pages #13

Merged
merged 7 commits into from
Jun 13, 2022
Merged

profile editing pages #13

merged 7 commits into from
Jun 13, 2022

Conversation

Ashishgy
Copy link
Contributor

@Ashishgy Ashishgy commented Jun 3, 2022

Profile Editing

  • [] - Added Profile Edit , Edit Skills, Edit Attitude, Edit Knowledge

Description

Added the pages with all the functionality of Edit User profile.

Checklist

  • Tested on all the devices.

@Ashishgy Ashishgy requested review from NMCarv and fbenfraj June 3, 2022 07:59
@vercel
Copy link

vercel bot commented Jun 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
gateway-website ✅ Ready (Inspect) Visit Preview Jun 13, 2022 at 11:21AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
ui-storybook ⬜️ Ignored (Inspect) Jun 13, 2022 at 11:21AM (UTC)

@Ashishgy Ashishgy removed request for NMCarv and fbenfraj June 3, 2022 08:09
apps/website/pages/profile/edit-attitudes.tsx Show resolved Hide resolved



const [arr, setArr] = useState([]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give more specific name than arr if possible

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to attitudes

apps/website/pages/profile/edit-knowledge.tsx Outdated Show resolved Hide resolved

const editProfile = () => {

useEffect(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have a JWT session system, no need to use the localStorage
For more details you might want to talk with @kbooz 😄

apps/website/pages/profile/edit-skills.tsx Outdated Show resolved Hide resolved
const file = e.target.files[0];

return new Promise((resolve, reject) => {
const reader = new FileReader();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why we need this

@fbenfraj fbenfraj changed the base branch from develop to feat/poc June 13, 2022 11:17
@fbenfraj fbenfraj merged commit 565e81b into feat/poc Jun 13, 2022
@NMCarv NMCarv deleted the feat/profile-edit branch October 26, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants