Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : guide card crashing issue and progress bar #159

Merged
merged 4 commits into from
Sep 23, 2022
Merged

Conversation

R11manish
Copy link
Member

fix guide card

Type of PR

  • - bugfix

ASANA LINK

@vercel
Copy link

vercel bot commented Sep 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
gateway-website ✅ Ready (Inspect) Visit Preview Sep 22, 2022 at 3:18PM (UTC)
1 Ignored Deployment
Name Status Preview Updated
ui-storybook ⬜️ Ignored (Inspect) Sep 22, 2022 at 3:18PM (UTC)

NMCarv
NMCarv previously requested changes Sep 19, 2022
Copy link
Member

@NMCarv NMCarv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

For some reason, the guide card is showing an extra step with no content for a completely new profile. I guess it has something to do with the way we're using details.length in this context (remembering indexes start from 0 rather than 1).

}
};

const redirectLink = (link: string): string => {
if (link == 'contribute') {
return `${ROUTES.EXPLORE}`;
}
return `${ROUTES.PROFILE_EDIT + details[progress].link}`;
return `${ROUTES.PROFILE_EDIT + details[progress]?.link}`;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if details[progress] can be undefined...you can add this: details?.[progress]?.link

@kbooz
Copy link
Member

kbooz commented Sep 22, 2022

image

last step is not filling the entire progress

@kbooz kbooz dismissed NMCarv’s stale review September 22, 2022 15:47

it was already fixed

@R11manish R11manish merged commit f8db0c5 into develop Sep 23, 2022
@kbooz kbooz deleted the fixes/guidecard branch May 23, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants