Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fetch notifications from redis #282

Merged
merged 7 commits into from
Nov 21, 2022
Merged

Conversation

fbenfraj
Copy link
Contributor

[PR Name]

Type of PR

  • [] - feature
  • [] - bugfix
  • [] - chore
  • [] - docs

Description

Lorem Ipsum

Checklist

  • [] - Provided useful description for this PR
  • [] - Provided the root cause of this bugfix
  • [] - Tested on supported devices

@fbenfraj fbenfraj requested a review from NMCarv November 17, 2022 15:45
@fbenfraj fbenfraj self-assigned this Nov 17, 2022
@vercel
Copy link

vercel bot commented Nov 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
gateway-website ✅ Ready (Inspect) Visit Preview Nov 21, 2022 at 6:48PM (UTC)
1 Ignored Deployment
Name Status Preview Updated
ui-storybook ⬜️ Ignored (Inspect) Nov 21, 2022 at 6:48PM (UTC)

};

return (
<Stack
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

@codeclimate
Copy link

codeclimate bot commented Nov 17, 2022

Code Climate has analyzed commit 0732fa8 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

View more on Code Climate.

'Content-Type': 'application/json',
},
body: JSON.stringify({
queueUrl: process.env.NEXT_PUBLIC_READ_NOTIFICATIONS_QUEUE_URL,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt this is secure

@@ -56,5 +56,8 @@
},
"label": "Wallet address or ENS name",
"input-helper": "Fill the addresses separated by comma"
},
"notifications": {
"published": "published a new ceredential: "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: ceredential => credential

apps/website/pages/api/notifications/index.ts Outdated Show resolved Hide resolved
@NMCarv NMCarv merged commit 39cdf1a into develop Nov 21, 2022
@NMCarv NMCarv deleted the feat/onplatform-notifications branch November 21, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants