-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes/conflict #283
Fixes/conflict #283
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
}, | ||
]; | ||
|
||
export function AdvancedSetting() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function AdvancedSetting
has 144 lines of code (exceeds 25 allowed). Consider refactoring.
Code Climate has analyzed commit 0876744 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing other than the two comments I made: if we try to insert any number on the expire date
field on the Advanced Settings, the website crashes. We need to fix that before I can approve the PR.
defaultValue={null} | ||
render={({ field: { onChange, value, ref } }) => { | ||
const isCustomValue = !claimLimitValues.some((btn) => btn.value === value); | ||
console.log(errors?.claim_limit, value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove console.log()
// claim_limit: null, | ||
// expire_date: null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove commented code
Type of PR