Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes/conflict #283

Merged
merged 5 commits into from
Nov 23, 2022
Merged

Fixes/conflict #283

merged 5 commits into from
Nov 23, 2022

Conversation

R11manish
Copy link
Member

Type of PR

  • - feature
  • - chore

@vercel
Copy link

vercel bot commented Nov 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
gateway-website ✅ Ready (Inspect) Visit Preview Nov 23, 2022 at 10:50PM (UTC)
1 Ignored Deployment
Name Status Preview Updated
ui-storybook ⬜️ Ignored (Inspect) Nov 23, 2022 at 10:50PM (UTC)

},
];

export function AdvancedSetting() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function AdvancedSetting has 144 lines of code (exceeds 25 allowed). Consider refactoring.

@codeclimate
Copy link

codeclimate bot commented Nov 22, 2022

Code Climate has analyzed commit 0876744 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

Copy link
Member

@NMCarv NMCarv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing other than the two comments I made: if we try to insert any number on the expire date field on the Advanced Settings, the website crashes. We need to fix that before I can approve the PR.

defaultValue={null}
render={({ field: { onChange, value, ref } }) => {
const isCustomValue = !claimLimitValues.some((btn) => btn.value === value);
console.log(errors?.claim_limit, value)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove console.log()

Comment on lines 39 to 40
// claim_limit: null,
// expire_date: null,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants