Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/data model credentials tab #333

Merged
merged 11 commits into from
Feb 8, 2023

Conversation

andrefelizardo
Copy link
Member

[Data Model/Credentials Tab]

Type of PR

  • - feature

Description

  • Component Data Grid
  • Component View Grid Tab
  • Use react-query to get credentials by data model
  • QR Code is still mocked

image

@vercel
Copy link

vercel bot commented Feb 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
gateway-website ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 8, 2023 at 11:14PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
ui-storybook ⬜️ Ignored (Inspect) Feb 8, 2023 at 11:14PM (UTC)

height={11}
/>
</NetworkTransactionLink>
<NetworkTransactionLink url="#">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

}
};

const defineCols = (columns: IColumnGrid[]) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function defineCols has 167 lines of code (exceeds 25 allowed). Consider refactoring.

</Box>
),
},
{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

column_name: 'minted',
cell: (params) => (
<Box sx={{ display: 'flex', gap: '5px', alignItems: 'center' }}>
<NetworkTransactionLink url="#">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.


export default function Loading(): JSX.Element {
return (
<Box
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 3 locations. Consider refactoring.

@codeclimate
Copy link

codeclimate bot commented Feb 8, 2023

Code Climate has analyzed commit b74f191 and detected 7 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2
Duplication 5

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants