Feat/protocol-fixes #339
Merged
Feat/protocol-fixes #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| const router = useRouter(); | ||
|
|
||
| return ( | ||
| <Link |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
| </Typography> | ||
| </CardCell> | ||
| <CardCell label={t('credential.status')}> | ||
| {!isDateExpired && ( | ||
| {credential?.status === 'Valid' && ( |
There was a problem hiding this comment.
Similar blocks of code found in 4 locations. Consider refactoring.
| <Chip | ||
| label={t('credential.valid')} | ||
| size="small" | ||
| variant="outlined" | ||
| color="success" | ||
| /> | ||
| )} | ||
| {isDateExpired && ( | ||
| {credential?.status === 'Suspended' && ( |
There was a problem hiding this comment.
Similar blocks of code found in 4 locations. Consider refactoring.
| size="small" | ||
| variant="outlined" | ||
| color="warning" | ||
| /> | ||
| )} | ||
| {/* {credential?.status === 'REVOKED' && ( | ||
| {credential?.status === 'Revoked' && ( |
There was a problem hiding this comment.
Similar blocks of code found in 4 locations. Consider refactoring.
| <Chip | ||
| label={t('credential.revoked')} | ||
| size="small" | ||
| variant="outlined" | ||
| color="warning" | ||
| /> | ||
| )} | ||
| {credential?.status === 'INVALID' && ( | ||
| {credential?.status === 'Invalid' && ( |
There was a problem hiding this comment.
Similar blocks of code found in 4 locations. Consider refactoring.
|
Code Climate has analyzed commit 1396bd1 and detected 6 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
kbooz
approved these changes
Feb 9, 2023
kbooz
requested changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protocol Fixes
Type of PR
Description
Lorem Ipsum
Checklist